Skip to content

[RELEASE-v1.7][SRVKS-971] Apply common name patch #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 8, 2022
Merged

[RELEASE-v1.7][SRVKS-971] Apply common name patch #69

openshift-merge-robot merged 1 commit into from
Dec 8, 2022

Conversation

@nak3
Copy link

@nak3 nak3 commented Dec 6, 2022

As per title, this adds the patch knative-extensions/control-protocol@4472b31

@openshift-ci openshift-ci bot requested review from mgencur and skonto December 6, 2022 09:25
@openshift-ci openshift-ci bot added the approved label Dec 6, 2022
@nak3
Copy link
Author

nak3 commented Dec 6, 2022

/cc @skonto

@skonto
Copy link

skonto commented Dec 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3db29e9 into openshift-knative:release-v1.7 Dec 8, 2022
@nak3
Copy link
Author

nak3 commented Dec 8, 2022

/cherrypick release-v1.6

@nak3
Copy link
Author

nak3 commented Dec 8, 2022

/cherrypick release-v1.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 8, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 8, 2022

@nak3: new pull request created: #72

Details

In response to this:

/cherrypick release-v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 8, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 8, 2022

@nak3: new pull request created: #73

Details

In response to this:

/cherrypick release-v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto skonto mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@skonto skonto Awaiting requested review from skonto

Assignees

@skonto skonto

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nak3 @skonto @openshift-cherrypick-robot @openshift-merge-robot