[release-1.9] cherry pick fixes (#13829) #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix G112: Potential Slowloris Attacks lint errs (knative#13702) * Fix queue proxy handler setup (knative#13815) - single handlers are now assosciated with multiple servers - main server is now shutdown - metrics should work whether we receive requests on TLS or HTTP --------- Co-authored-by: kmahapatra <kmahapatra@vmware.com>
ReToCode
approved these changes
Apr 13, 2023
ReToCode
left a comment
There was a problem hiding this comment.
/lgtm
/hold for tests, feel free to unhold if they pass.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cherry-picks 92301fb and sync with upstream 1.9.3.