Skip to content

Conversation

@pierDipi
Copy link
Member

Cherry-pick of knative@28c489e

…ormer (knative#8418)

* Reduce mt-broker-controller memory usage with namespaced endpoint informer

Currently, the mt-broker-controller is using a cluster-wide endpoints
informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE".

Using the namespaced informer factory ensures that the watcher
is only watching endpoints in the `knative-eventing` (also known as
`SYSTEM_NAMESPACE`) namespace.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Start informer

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and creydr January 23, 2025 15:59
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/cherry-pick release-v1.16

@openshift-cherrypick-robot

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.16 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-v1.17

@openshift-cherrypick-robot

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/test 417-test-reconciler

@pierDipi pierDipi merged commit 52188f5 into openshift-knative:release-v1.15 Jan 28, 2025
31 of 59 checks passed
@openshift-cherrypick-robot

@pierDipi: new pull request created: #1012

Details

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@pierDipi: cannot checkout release-v1.17: error checking out "release-v1.17": exit status 1 error: pathspec 'release-v1.17' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants