Skip to content

move old direct etcd methods for policy closer to source#15863

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:rbac-02-scope
Aug 18, 2017
Merged

move old direct etcd methods for policy closer to source#15863
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:rbac-02-scope

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Aug 18, 2017

This moves the old legacy etcd packages for the authorization resources to their only caller. We don't want anyone confused about why they are here and this puts them all in one nice spot for deletion.

@deads2k deads2k assigned enj and simo5 Aug 18, 2017
@openshift-merge-robot openshift-merge-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2017
@enj
Copy link
Copy Markdown
Contributor

enj commented Aug 18, 2017

/lgtm this covers part of #15817

@enj
Copy link
Copy Markdown
Contributor

enj commented Aug 18, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2017
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enj
Copy link
Copy Markdown
Contributor

enj commented Aug 18, 2017

@deads2k needs a hack/verify-gofmt.sh | xargs -n 1 gofmt -s -w

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 18, 2017
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Automatic merge from submit-queue (batch tested with PRs 15693, 15857, 15860, 15863)

@openshift-merge-robot openshift-merge-robot merged commit a9a401c into openshift:master Aug 18, 2017
@deads2k deads2k deleted the rbac-02-scope branch January 24, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants