dockerfile/parser: use custom 2mb buffer for long-texts #261
dockerfile/parser: use custom 2mb buffer for long-texts #261openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
|
LGTM |
|
LGTM |
dockerfile/parser/parser.go
Outdated
| } | ||
|
|
||
| scannerErr := scanner.Err() | ||
| if scannerErr != nil { |
There was a problem hiding this comment.
Go ahead and use the if scannerErr := scanner.Err(); scannerErr != nil { form here, since scannerErr isn't going to be used anywhere else.
|
One nit, otherwise LGTM. |
Scanner errors are silently ignored, following commit makes sure we don't do that. Signed-off-by: Aditya R <arajan@redhat.com>
Containerfile may contain long lines lets use custom buffer for such use-cases. Signed-off-by: Aditya R <arajan@redhat.com>
7d107f2 to
ab364dd
Compare
|
@flouthoc: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Containerfile may contain long lines lets use custom buffer for such
use-cases.
Closes: containers/buildah#4929