Skip to content

Upgrade to use k8s v0.34.1#342

Closed
camilamacedo86 wants to merge 1 commit intoopenshift:masterfrom
camilamacedo86:upgrade-k8s
Closed

Upgrade to use k8s v0.34.1#342
camilamacedo86 wants to merge 1 commit intoopenshift:masterfrom
camilamacedo86:upgrade-k8s

Conversation

@camilamacedo86
Copy link

@camilamacedo86 camilamacedo86 commented Oct 14, 2025 •
edited
Loading

Description

Update the dependencies to use k8s 1.34.1

Note that the change is only in the go.mod : https://github.com/openshift/client-go/blob/71a33fc8804f6252c5a3374c4b006ac40922037f/go.mod
All files are vendor.

Motivation

  • Solve CVE
  • Make the client-go compatible with 4.21 release
  • Unblock any project that uses client-go and wants to upgrade the dependencies to 1.34 since it will fail because of the replacement of sigs.k8s.io/structured-merge-diff/v4/typed to sigs.k8s.io/structured-merge-diff/v6/typed which is required to solve CVE

c/c @jacobsee

Closes: #332

@openshift-ci openshift-ci bot requested review from bertinatto and deads2k October 14, 2025 09:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This was referenced Oct 14, 2025
Closed
Merged
@Meina-rh
Copy link

Meina-rh commented Oct 21, 2025

@camilamacedo86 when is this PR expected to be merged? we're waiting for sigs.k8s.io/structured-merge-diff/v6 change.

@camilamacedo86
Copy link
Author

camilamacedo86 commented Oct 21, 2025

It is done already now
We can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@deads2k deads2k Awaiting requested review from deads2k

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamacedo86 @Meina-rh