We were only looking at a single direction-type node within a direction node, but there can be multiple:
https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/direction/
This is now fixed, e.g. the "Feierlich" direction in "Land der Berge" was missing in OSMD, because direction node included a metronome mark first.
Another sample where metronome mark was missing:
izljazal-e-sejach.zip
There is another potential spot where we're not looking at multiple direction-type nodes in InstrumentReader (else if (xmlNode.name === "direction") ), but doing the same change there doesn't fix anything as far as I'm aware and introduces duplicated word-nodes that we'd have to filter (e.g. showing "Moderato" twice).
We were only looking at a single direction-type node within a direction node, but there can be multiple:
https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/direction/
This is now fixed, e.g. the "Feierlich" direction in "Land der Berge" was missing in OSMD, because direction node included a metronome mark first.
Another sample where metronome mark was missing:
izljazal-e-sejach.zip
There is another potential spot where we're not looking at multiple direction-type nodes in InstrumentReader (
else if (xmlNode.name === "direction")), but doing the same change there doesn't fix anything as far as I'm aware and introduces duplicated word-nodes that we'd have to filter (e.g. showing "Moderato" twice).