Deprecate span collector#990
Merged
dai-chen merged 10 commits intoopensearch-project:feature/maximus-m1from Nov 8, 2022
Merged
Deprecate span collector#990dai-chen merged 10 commits intoopensearch-project:feature/maximus-m1from
dai-chen merged 10 commits intoopensearch-project:feature/maximus-m1from
Conversation
Signed-off-by: Chen Dai <daichen@amazon.com>
43 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.67%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feature/maximus-m1 #990 +/- ##
========================================================
- Coverage 98.27% 95.67% -2.61%
+ Complexity 3396 3389 -7
========================================================
Files 339 348 +9
Lines 8545 9071 +526
Branches 561 659 +98
========================================================
+ Hits 8398 8679 +281
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Yury-Fridlyand
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Dai daichen@amazon.com
Description
Background
SpanCollectoris an implementation class ofCollectorinterface. InAggregationOperator, it's used to generate span start point for anExprValue(incollector.bucketKey()which is similar responsibility asWindowAssigner). Eventually,AggregationOperatorwill fetch all results (incollector.results()).Problems
For some reason,
SpanCollectordoesn't convert aggregate result map toExprValuesimply and return it toAggregationOperator. Instead, it calculates result array size and locate each map key again. This is probably to support filling gaps between windows as example shown below:Solution in the PR
However, after testing both current span and OpenSearch histogram DSL query, this complicated logic is no use any more. This PR is to deprecate it and remove unused code in
Roundingclass correspondingly. This preparesAggregationOperatorandRoundingfor the upcoming stream processing changes.Testing
Both PPL and DSL query returns only bucket which has data:
Issues Resolved
#954
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.