Add stream context and window trigger#958
Merged
dai-chen merged 2 commits intoopensearch-project:feature/maximus-m1from Nov 1, 2022
Merged
Add stream context and window trigger#958dai-chen merged 2 commits intoopensearch-project:feature/maximus-m1from
dai-chen merged 2 commits intoopensearch-project:feature/maximus-m1from
Conversation
43 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.22%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feature/maximus-m1 #958 +/- ##
========================================================
- Coverage 97.96% 95.22% -2.74%
- Complexity 3154 3157 +3
========================================================
Files 303 315 +12
Lines 7805 8469 +664
Branches 504 623 +119
========================================================
+ Hits 7646 8065 +419
- Misses 158 350 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Chen Dai <daichen@amazon.com>
2c5c7ae to
f3db6ad
Compare
Signed-off-by: Chen Dai <daichen@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As another main component for stream data windowing, this PR adds Window Trigger along with Stream Context.
Stream Context
A stream context holds useful context information for all stream processing components. It’s also easy to store and restore between executions by put all state in one place.
Window Trigger
A window trigger determines whether to trigger window state output (a window pane). Common trigger implementation includes:
Note that window trigger is easy to be confused with watermark. Watermark is the way to reason about the completeness of window state. Window trigger upon user configuration can decide to trigger output no matter the window state is complete or not.
Issues Resolved
#951
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.