remove opensearch.sql.engine.new.enabled setting#70
Merged
penghuo merged 5 commits intoopensearch-project:developfrom May 19, 2021
Merged
remove opensearch.sql.engine.new.enabled setting#70penghuo merged 5 commits intoopensearch-project:developfrom
penghuo merged 5 commits intoopensearch-project:developfrom
Conversation
Signed-off-by: penghuo <penghuo@gmail.com>
Contributor
|
Here is another doc that needs to be updated: https://github.com/opensearch-project/sql/blob/main/docs/dev/NewSQLEngine.md#34-what-if-something-wrong |
Collaborator
Author
Done. https://github.com/penghuo/os-sql/blob/pr-issue58/docs/dev/NewSQLEngine.md |
… because there is no enough memory Signed-off-by: penghuo <penghuo@gmail.com>
chloe-zh
approved these changes
May 19, 2021
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: penghuo penghuo@gmail.com
Description
Remove the opensearch.sql.engine.new.enabled. The opensearch.sql.engine.new.enabled setting is added and set to default true on ODFE 1.13.0.0, the major purpose is to safely publish the new engine, in any case, the customer found issue, they still have the way to rollback to the legacy engine.
We didn't found major issue with new engine, so we decide to fullly enable it by default. If there are any case the new engine can't handle, it still fallback to the the legacy engine automatically. So, there is no impact for the customer.
Issues Resolved
#58
To Reviewers
The PR include the following changes
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.