Skip to content

[Backport 2.19-dev]Remove redundant push-down-filters derived for bucket-non-null agg (#4843)#4851

Merged
yuancu merged 3 commits intoopensearch-project:2.19-devfrom
qianheng-aws:backport/backport-4843-to-2.19-dev
Nov 25, 2025
Merged

[Backport 2.19-dev]Remove redundant push-down-filters derived for bucket-non-null agg (#4843)#4851
yuancu merged 3 commits intoopensearch-project:2.19-devfrom
qianheng-aws:backport/backport-4843-to-2.19-dev

Conversation

@qianheng-aws
Copy link
Copy Markdown
Collaborator

Backport ede63cb from #4843.

…pensearch-project#4843)

* Remove redundant push-down-filters derived for bucket-non-null aggregation

Signed-off-by: Heng Qian <qianheng@amazon.com>

* Address comment

Signed-off-by: Heng Qian <qianheng@amazon.com>

* Fix name typo

Signed-off-by: Heng Qian <qianheng@amazon.com>

---------

Signed-off-by: Heng Qian <qianheng@amazon.com>

(cherry picked from commit ede63cb)
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-aws
Copy link
Copy Markdown
Collaborator Author

Tests with failures:
 - org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByIPs
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByIPs
 - org.opensearch.sql.ppl.dashboard.WafPplDashboardIT.testTopTerminatingRules

@LantaoJin @yuancu Have you met this failure before? It's weird I cannot reproduce them locally with the given command, e.g.

./gradlew ':integ-test:integTest' --tests 'org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags' -Dtests.seed=61CD58CB24A1BC70 -Dtests.security.manager=false -Dtests.locale=pt -Dtests.timezone=Asia/Saigon -Druntime.java=11

Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-aws
Copy link
Copy Markdown
Collaborator Author

Tests with failures:
 - org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByIPs
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByIPs
 - org.opensearch.sql.ppl.dashboard.WafPplDashboardIT.testTopTerminatingRules

@LantaoJin @yuancu Have you met this failure before? It's weird I cannot reproduce them locally with the given command, e.g.

./gradlew ':integ-test:integTest' --tests 'org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags' -Dtests.seed=61CD58CB24A1BC70 -Dtests.security.manager=false -Dtests.locale=pt -Dtests.timezone=Asia/Saigon -Druntime.java=11

Implicitly adding sort order on all fields to ensure sequence of the final results.

@yuancu yuancu merged commit 93b5a74 into opensearch-project:2.19-dev Nov 25, 2025
45 checks passed
@qianheng-aws qianheng-aws deleted the backport/backport-4843-to-2.19-dev branch March 26, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants