[Backport 2.19-dev] Fix span on negative timestamp#4028
Merged
Conversation
* Fix span on negative timestamp Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix span on negative timestamp Signed-off-by: Heng Qian <qianheng@amazon.com> * typo Signed-off-by: Heng Qian <qianheng@amazon.com> * Refine code Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit ad3fc1f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dai-chen
approved these changes
Aug 13, 2025
Collaborator
I've seen this failure before. Is it flaky? |
Collaborator
|
@qianheng-aws could you check the CI failure? |
Collaborator
It's flakey and not related to this change. I've seen it several times before. Shall we disable q7 until we find the root cause of the flakey? @LantaoJin |
Member
Okey, let me add some retry for q7. The q7 may fail sometimes with socket timeout on mac/windows. |
LantaoJin
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ad3fc1f from #4017.