Remove Datetime data type#1980
Merged
Yury-Fridlyand merged 8 commits intoopensearch-project:mainfrom Aug 21, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
============================================
- Coverage 97.33% 97.30% -0.04%
+ Complexity 4657 4621 -36
============================================
Files 408 407 -1
Lines 12097 11932 -165
Branches 829 826 -3
============================================
- Hits 11775 11610 -165
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
You need to rerun spotless on files you modified and commit the changes from spotless
core/src/test/java/org/opensearch/sql/data/model/DateTimeValueTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/data/model/ExprValueCompareTest.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/data/model/ExprValueCompareTest.java
Show resolved
Hide resolved
acarbonetto
previously approved these changes
Aug 17, 2023
acarbonetto
reviewed
Aug 17, 2023
24d6417 to
36e4a07
Compare
Yury-Fridlyand
previously approved these changes
Aug 18, 2023
* removed datetime type, updated tests and documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…constant Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…e difference Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Contributor
|
There are some conflicts to resolve @matthewryanwells |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
cc12e92 to
5597643
Compare
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Contributor
Author
Just resolved the merge conflicts |
acarbonetto
approved these changes
Aug 21, 2023
Yury-Fridlyand
approved these changes
Aug 21, 2023
6 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
DATETIMEdata type as it is made redundant by the presence ofTIMESTAMP.Updated all functions that returned
DATETIMEto now returnTIMESTAMPand removed it from all other functions, tests, and documentation.Issues Resolved
#1176
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.