Skip to content

[Backport 2.x] [Spotless] Adds new line at end of java files#1925

Merged
acarbonetto merged 2 commits into2.xfrom
backport/backport-1896-to-2.x
Aug 4, 2023
Merged

[Backport 2.x] [Spotless] Adds new line at end of java files#1925
acarbonetto merged 2 commits into2.xfrom
backport/backport-1896-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport d2de909 from #1896.

* Adding spotless plugin to project build.gradle.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Remove commented out spotless changes.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Adding Spotless to DEVELOPER_GUIDE.rst

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Added Google Java format to spotless.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Update DEVELOPER_GUIDE.rst

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Added apply false for spotless

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Adding ratchetFrom to build.gradle

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Adding license header to build.gradle for spotless.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Uncommenting all changes to build.gradle for spotless.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Commented out spotless checks.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Add specific version for java format spotless (1.17.0)

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Add spotless end with new line check.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Add new line at end of files missing lines.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Removed include path

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Correcting ending new line for QueryExemplars.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit d2de909)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1925 (6a5b5d0) into 2.x (a297d33) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1925   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4648     4648           
=========================================
  Files           408      408           
  Lines         11528    11528           
  Branches        839      839           
=========================================
  Hits          11231    11231           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ression/operator/arthmetic/ArithmeticFunction.java 100.00% <ø> (ø)
...g/opensearch/sql/expression/text/TextFunction.java 100.00% <ø> (ø)
...earch/sql/datasources/encryptor/EncryptorImpl.java 100.00% <ø> (ø)
...model/transport/CreateDataSourceActionRequest.java 27.27% <ø> (ø)
...odel/transport/CreateDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/DeleteDataSourceActionRequest.java 18.75% <ø> (ø)
...odel/transport/DeleteDataSourceActionResponse.java 0.00% <ø> (ø)
...es/model/transport/GetDataSourceActionRequest.java 27.27% <ø> (ø)
...s/model/transport/GetDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/UpdateDataSourceActionRequest.java 27.27% <ø> (ø)
... and 13 more

…96-to-2.x

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@acarbonetto acarbonetto merged commit 5c91071 into 2.x Aug 4, 2023
@github-actions github-actions bot deleted the backport/backport-1896-to-2.x branch August 4, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants