[Backport 2.x] Adding Spotless support framework #1888#1898
Merged
GumpacG merged 1 commit intoopensearch-project:2.xfrom Jul 27, 2023
Merged
[Backport 2.x] Adding Spotless support framework #1888#1898GumpacG merged 1 commit intoopensearch-project:2.xfrom
GumpacG merged 1 commit intoopensearch-project:2.xfrom
Conversation
c20fd0f to
e1c20ca
Compare
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
e1c20ca to
77832ca
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #1898 +/- ##
=========================================
Coverage 97.41% 97.41%
Complexity 4642 4642
=========================================
Files 408 408
Lines 11506 11506
Branches 839 839
=========================================
Hits 11209 11209
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yury-Fridlyand
approved these changes
Jul 27, 2023
GumpacG
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Spotless code formatter via ./gradlew spotlessApply and ./gradlew spotlessCheck. Apply applies the checks, check notifies which changes need to be applied.
Proposed checks commented out:
License header
Import order - sorts imports
Remove unused imports
Trim trailing whitespace
End with newline
Google Java format - https://github.com/google/google-java-format
Note: proposed spotless checks will be commented out until fix for each individual is merged. Lines will be uncommented as part of PRs addressing change.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.