Use externally-defined OpenSearch version when specified.#179
Merged
dblock merged 1 commit intoopensearch-project:mainfrom Aug 13, 2021
Merged
Use externally-defined OpenSearch version when specified.#179dblock merged 1 commit intoopensearch-project:mainfrom
dblock merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: dblock <dblock@amazon.com>
dblock
commented
Aug 13, 2021
|
|
||
| allprojects { | ||
| version = "${opensearchVersion}.0" | ||
| version = "${opensearchVersion}" - "-SNAPSHOT" + ".0" |
Member
Author
There was a problem hiding this comment.
Otherwise I end up with a 1.0.0-SNAPSHOT-0 artifact.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=========================================
Coverage 99.89% 99.89%
Complexity 2512 2512
=========================================
Files 245 245
Lines 5853 5853
Branches 342 342
=========================================
Hits 5847 5847
Misses 5 5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
chloe-zh
approved these changes
Aug 13, 2021
Contributor
chloe-zh
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
Allows one to run
./gradlew build --no-daemon -Dopensearch.version=1.0.0-SNAPSHOT -Dbuild.snapshot=trueto produce a-SNAPSHOTartifact that correctly depends on the-SNAPSHOTbuild of OpenSearch.Issues Resolved
Closes #177
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.