[Backport 2.x] Added COSH to V2 engine#1565
Merged
dai-chen merged 1 commit intoopensearch-project:2.xfrom Apr 20, 2023
Merged
Conversation
* Added COSH to V2 engine, updated documentation, unit/IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit 8dad71f)
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #1565 +/- ##
============================================
- Coverage 98.46% 97.19% -1.28%
- Complexity 3867 4107 +240
============================================
Files 345 371 +26
Lines 9600 10464 +864
Branches 616 706 +90
============================================
+ Hits 9453 10170 +717
- Misses 142 287 +145
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 59 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MaxKsyunz
approved these changes
Apr 20, 2023
Contributor
Author
|
@rupal-bq @chenqi0805 @penghuo This was missed from being added to 2.7, should we add it in now? Edit: this isn't a very important ticket so it doesn't greatly matter if it gets in or not but would be nice |
acarbonetto
approved these changes
Apr 20, 2023
Yury-Fridlyand
approved these changes
Apr 20, 2023
dai-chen
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backporting #1428 to 2.x
Issues Resolved
#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.