Skip to content

Fix AstExpressionBuilder.java in 2.7 for backport 1456 to 2.7#1513

Merged
MaxKsyunz merged 1 commit intoopensearch-project:backport/backport-1456-to-2.7from
Bit-Quill:integ-backport-1456-to-2.7
Apr 11, 2023
Merged

Fix AstExpressionBuilder.java in 2.7 for backport 1456 to 2.7#1513
MaxKsyunz merged 1 commit intoopensearch-project:backport/backport-1456-to-2.7from
Bit-Quill:integ-backport-1456-to-2.7

Conversation

@acarbonetto
Copy link
Copy Markdown
Collaborator

Description

Fix build for #1509

Issues Resolved

#1509

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
@acarbonetto acarbonetto requested a review from a team as a code owner April 10, 2023 22:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (c539f07) to head (318bdfc).

Additional details and impacted files
@@                         Coverage Diff                         @@
##             backport/backport-1456-to-2.7    #1513      +/-   ##
===================================================================
+ Coverage                            98.41%   98.49%   +0.07%     
- Complexity                            3727     3926     +199     
===================================================================
  Files                                  335      347      +12     
  Lines                                 9281     9768     +487     
  Branches                               599      645      +46     
===================================================================
+ Hits                                  9134     9621     +487     
  Misses                                 142      142              
  Partials                                 5        5              
Flag Coverage Δ
sql-engine 98.49% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen
Copy link
Copy Markdown
Collaborator

dai-chen commented Apr 11, 2023

You may want to send a single backport PR instead of two?

@MaxKsyunz MaxKsyunz merged commit db59bd2 into opensearch-project:backport/backport-1456-to-2.7 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants