Skip to content

[Backport 2.x] Added SIGNUM function to V2 engine#1442

Merged
Yury-Fridlyand merged 1 commit into2.xfrom
backport/backport-1429-to-2.x
Mar 17, 2023
Merged

[Backport 2.x] Added SIGNUM function to V2 engine#1442
Yury-Fridlyand merged 1 commit into2.xfrom
backport/backport-1429-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport 6496692 from #1429

* Added SIGNUM function to V2 engine (#241)

* Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* fixed merge mistake

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* fixed merging error

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 6496692)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 15, 2023 21:07
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (014de25) to head (e56af86).
⚠️ Report is 386 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #1442   +/-   ##
=========================================
  Coverage     98.38%   98.38%           
- Complexity     3702     3705    +3     
=========================================
  Files           343      343           
  Lines          9125     9130    +5     
  Branches        582      582           
=========================================
+ Hits           8978     8983    +5     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen dai-chen added the enhancement New feature or request label Mar 16, 2023
@dai-chen
Copy link
Copy Markdown
Collaborator

Failed on a IT. Retrying

2023-03-15T21:19:28.6355767Z   2> REPRODUCE WITH: ./gradlew ':integ-test:integTest' --tests "org.opensearch.sql.ppl.PrometheusDataSourceCommandsIT.testSourceMetricCommandWithTimestamp" -Dtests.seed=8556746038C8F76E -Dtests.security.manager=false -Dtests.locale=hi-IN -Dtests.timezone=Africa/Lome -Druntime.java=17
2023-03-15T21:19:28.6356466Z         "reason": "Invalid Query",
2023-03-15T21:19:28.6357489Z   2> org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:36873], URI [/_plugins/_ppl], status line [HTTP/1.1 400 Bad Request]
2023-03-15T21:19:28.6376325Z         "details": "timestamp:२०२३-०३-१५ २०:१९:२८ in unsupported format, please use yyyy-MM-dd HH:mm:ss[.SSSSSSSSS]",
2023-03-15T21:19:28.6376825Z     {
2023-03-15T21:19:28.6377011Z       "error": {
2023-03-15T21:19:28.6377223Z         "reason": "Invalid Query",
2023-03-15T21:19:28.6377809Z         "details": "timestamp:२०२३-०३-१५ २०:१९:२८ in unsupported format, please use yyyy-MM-dd HH:mm:ss[.SSSSSSSSS]",
2023-03-15T21:19:28.6378167Z         "type": "SemanticCheckException"
2023-03-15T21:19:28.6378438Z       },
2023-03-15T21:19:28.6378618Z       "status": 400
2023-03-15T21:19:28.6378829Z     }

@Yury-Fridlyand Yury-Fridlyand merged commit 3ea6c5c into 2.x Mar 17, 2023
@github-actions github-actions bot deleted the backport/backport-1429-to-2.x branch March 17, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants