Skip to content

[Backport 2.x] Added RINT function to V2 engine #1439

Merged
Yury-Fridlyand merged 1 commit into2.xfrom
backport/backport-1433-to-2.x
Mar 15, 2023
Merged

[Backport 2.x] Added RINT function to V2 engine #1439
Yury-Fridlyand merged 1 commit into2.xfrom
backport/backport-1433-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Mar 15, 2023

Backport 7220cfe from #1433

@matthewryanwells @github-actions
Added RINT function to V2 engine (#240) (#1433)
0630379 
Added RINT to V2 engine, updated documentation, added unit and IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 7220cfe)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 15, 2023 17:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2023 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (0b6e581) to head (0630379).
⚠️ Report is 388 commits behind head on 2.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x    #1439   +/-   ##
=========================================
  Coverage     98.38%   98.38%           
- Complexity     3696     3699    +3     
=========================================
  Files           343      343           
  Lines          9115     9120    +5     
  Branches        582      582           
=========================================
+ Hits           8968     8973    +5     
  Misses          142      142           
  Partials          5        5
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen dai-chen added the enhancement New feature or request label Mar 15, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 014de25 into 2.x Mar 15, 2023
@github-actions github-actions bot deleted the backport/backport-1433-to-2.x branch March 15, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-chen dai-chen dai-chen approved these changes

+1 more reviewer

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codecov-commenter @dai-chen @Yury-Fridlyand @matthewryanwells