Skip to content

[Backport 2.x] Fix truncate() function#1213

Merged
dai-chen merged 1 commit into2.xfrom
backport/backport-1197-to-2.x
Jan 3, 2023
Merged

[Backport 2.x] Fix truncate() function#1213
dai-chen merged 1 commit into2.xfrom
backport/backport-1197-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jan 3, 2023

Backport 7714819 from #1197

@margarit-h @github-actions
Fix truncate() function (#1197)
e14cca1 
* Fix truncate() function (#188)

Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
(cherry picked from commit 7714819)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 3, 2023 17:49
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 3, 2023 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.83%. Comparing base (753847b) to head (e14cca1).
⚠️ Report is 445 commits behind head on 2.x.

❌ Your project status has failed because the head coverage (95.83%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x    #1213      +/-   ##
============================================
- Coverage     98.32%   95.83%   -2.49%     
  Complexity     3552     3552              
============================================
  Files           346      356      +10     
  Lines          8757     9415     +658     
  Branches        554      673     +119     
============================================
+ Hits           8610     9023     +413     
- Misses          142      334     +192     
- Partials          5       58      +53
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen dai-chen added the bug Something isn't working label Jan 3, 2023
@dai-chen dai-chen merged commit d7825f4 into 2.x Jan 3, 2023
@github-actions github-actions bot deleted the backport/backport-1197-to-2.x branch January 3, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes

@dai-chen dai-chen dai-chen approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codecov-commenter @penghuo @dai-chen @margarit-h