Add cbrt function to the PPL#1097
Merged
Yury-Fridlyand merged 3 commits intoopensearch-project:2.xfrom Nov 28, 2022
Merged
Conversation
* Add cbrt function to the PPL Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.78%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 2.x #1097 +/- ##
============================================
- Coverage 98.28% 95.78% -2.51%
- Complexity 3454 3465 +11
============================================
Files 345 357 +12
Lines 8588 9305 +717
Branches 547 669 +122
============================================
+ Hits 8441 8913 +472
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dai-chen
reviewed
Nov 23, 2022
integ-test/src/test/java/org/opensearch/sql/ppl/MathematicalFunctionIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
dai-chen
approved these changes
Nov 28, 2022
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Yury-Fridlyand
approved these changes
Nov 28, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Margarit Hakobyan margarith@bitquilltech.com
Description
Calculates the cube root of a number
Argument type: INTEGER/LONG/FLOAT/DOUBLE
Return type DOUBLE:
(Non-negative) INTEGER/LONG/FLOAT/DOUBLE -> DOUBLE
(Negative) INTEGER/LONG/FLOAT/DOUBLE -> DOUBLE
Example::
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.