-
Notifications
You must be signed in to change notification settings - Fork 190
[DISCUSSION] Remove totalHits feature from pagination in V2 #1581
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or requestpaginationPagination feature, ref #656Pagination feature, ref #656
Description
Is your feature request related to a problem?
A discussion started from this post in #1497 raised a question: should we implement this feature or remove it (revert)?
If we keep this feature
Procs
- Compatibility with legacy engine
- Proper use of
totalandsizein the response - these values were always equal before
Cons
- Rework required, implementation is not good
- It is not used; main consumer of JDBC response format is the JDBC driver which ignores both these values
If we remove this feature
Procs
- Reduce impact of pagination feature
Cons
- A breaking change: legacy engine properly sets
totalandsizefor paging requests
Note: it is still not used by JDBC (ref: JsonQueryResponse).
Please, feel free to edit procs/cons lists above and post your votes. Removal was already discussed in meetings and in the slack channel, but should be posted/copied here for visibility.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestpaginationPagination feature, ref #656Pagination feature, ref #656