Skip to content

[DISCUSSION] Remove totalHits feature from pagination in V2 #1581

@Yury-Fridlyand

Description

@Yury-Fridlyand

Is your feature request related to a problem?

A discussion started from this post in #1497 raised a question: should we implement this feature or remove it (revert)?

If we keep this feature

Procs

  1. Compatibility with legacy engine
  2. Proper use of total and size in the response - these values were always equal before

Cons

  1. Rework required, implementation is not good
  2. It is not used; main consumer of JDBC response format is the JDBC driver which ignores both these values

If we remove this feature

Procs

  1. Reduce impact of pagination feature

Cons

  1. A breaking change: legacy engine properly sets total and size for paging requests
    Note: it is still not used by JDBC (ref: JsonQueryResponse).

Please, feel free to edit procs/cons lists above and post your votes. Removal was already discussed in meetings and in the slack channel, but should be posted/copied here for visibility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpaginationPagination feature, ref #656

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions