Skip to content

Commit acecdd1

Browse files
committed
address comments
Signed-off-by: Heng Qian <qianheng@amazon.com>
1 parent bdfc888 commit acecdd1

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4415.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,5 @@ teardown:
3838
query: source=test | bin num bins=3 | stats count() by num
3939

4040
- match: { total: 2 }
41+
- match: { "schema": [ { "name": "count()", "type": "bigint" }, { "name": "num", "type": "string" }] }
4142
- match: {"datarows": [[2, "10-20"], [1, "20-30"]]}

opensearch/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -972,7 +972,7 @@ public void constructUnsupportedTypeThrowException() {
972972

973973
@Test
974974
// aggregation adds info about new columns to the factory,
975-
// it will overwrite existing type to fix issue #4413.
975+
// it will overwrite existing type to fix https://github.com/opensearch-project/sql/issues/4115
976976
public void factoryMappingsAreExtendableWithOverWrite()
977977
throws NoSuchFieldException, IllegalAccessException {
978978
var factory =

0 commit comments

Comments
 (0)