[Backport 2.0] Select tenant popup only appears when multi-tenacy is enabled#970
Merged
[Backport 2.0] Select tenant popup only appears when multi-tenacy is enabled#970
Conversation
The current behavoir is that all users will see a message to switch tenants and if multi-tenancy is disabled, that message will be prompting the user to ask the admin to enable the feature. This is causing users pain that are not interested in using the tenancy features. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit ec59de0)
peternied
requested changes
Apr 26, 2022
Member
peternied
left a comment
There was a problem hiding this comment.
Preventing this change from being merged until the 2.0.0-rc1 release has been created.
DarshitChanpura
approved these changes
May 10, 2022
peternied
approved these changes
May 10, 2022
DarshitChanpura
approved these changes
May 16, 2022
Codecov Report
@@ Coverage Diff @@
## 2.0 #970 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 247 247
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ec59de0 from #965