Skip to content

[Backport to 2.0] Fix 'openserach' typo in constants.tsx (#953)#961

Merged
peternied merged 1 commit intoopensearch-project:2.0from
ylwu-amzn:backport_2.0
May 11, 2022
Merged

[Backport to 2.0] Fix 'openserach' typo in constants.tsx (#953)#961
peternied merged 1 commit intoopensearch-project:2.0from
ylwu-amzn:backport_2.0

Conversation

@ylwu-amzn
Copy link
Copy Markdown
Contributor

Signed-off-by: Cam McKenzie camAtGitHub@users.noreply.github.com

Description

Backport PR #953 to 2.0

Category

bug fix

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team April 21, 2022 22:50
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #961 (662d7ed) into 2.0 (7420eb2) will not change coverage.
The diff coverage is n/a.

❗ Current head 662d7ed differs from pull request most recent head a11e4da. Consider uploading reports for the commit a11e4da to get more accurate results

@@           Coverage Diff           @@
##              2.0     #961   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      242      242           
=======================================
  Hits         1375     1375           
  Misses        477      477           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7420eb2...a11e4da. Read the comment docs.

Signed-off-by: Cam <camAtGitHub@users.noreply.github.com>
@cliu123
Copy link
Copy Markdown
Member

cliu123 commented Apr 21, 2022

@ylwu-amzn This PR needs to be included in the release notes if this will be merged to 2.0. The release notes change also needs to be made in main, 2.x and 2.0 branches.

Copy link
Copy Markdown
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not approved for the 2.0.0-rc1 release.

@ylwu-amzn
Copy link
Copy Markdown
Contributor Author

ylwu-amzn commented Apr 22, 2022

This change is not approved for the 2.0.0-rc1 release.

Thanks @peternied for adding this. We should merge this PR after 2.0-rc1 release.

@peternied peternied added the v2.0.0-GeneralAvailability For changes that should only be included in the 2.0.0-GA release label Apr 28, 2022
@ylwu-amzn
Copy link
Copy Markdown
Contributor Author

I have no permission to merge PR. Security team please help merge.

@peternied peternied merged commit b5927a1 into opensearch-project:2.0 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2.0.0-GeneralAvailability For changes that should only be included in the 2.0.0-GA release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants