Skip to content

Updated issue templates from .github.#931

Merged
peternied merged 3 commits intoopensearch-project:mainfrom
dblock:meta-templates
Apr 8, 2022
Merged

Updated issue templates from .github.#931
peternied merged 3 commits intoopensearch-project:mainfrom
dblock:meta-templates

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Apr 4, 2022 •
edited
Loading

Signed-off-by: dblock dblock@dblock.org

Description

Coming from opensearch-project/.github#64, updated issue templates for bugs and features.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team April 4, 2022 19:51
peternied
peternied previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on

@dblock
Updated issue templates from .github.
fe7150e 
Signed-off-by: dblock <dblock@dblock.org>
peternied
peternied previously approved these changes Apr 4, 2022
View reviewed changes
peternied
peternied previously approved these changes Apr 4, 2022
View reviewed changes
@dblock
Copy link
Copy Markdown
Member Author

dblock commented Apr 4, 2022

@peternied Looks like CI is failing with real albeit unexpected failures, help?

@peternied peternied mentioned this pull request Apr 5, 2022
Closed
@peternied
Copy link
Copy Markdown
Member

peternied commented Apr 5, 2022

Looks like main is broken due do the default version of dashboards changing out from underneath this repo. I'll make sure another maintainer approves this change and then I'll merge it past the build break. Tracking issue, #932

Not-so-useful failure:

Plugin "securityDashboards" is only compatible with OpenSearch Dashboards version "1.3.0", but used OpenSearch Dashboards version is "1.4.0". (incompatible-version, /home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/plugins/security-dashboards-plugin/opensearch_dashboards.json)

@dblock dblock mentioned this pull request Apr 6, 2022
Closed
21 tasks
cliu123
cliu123 reviewed Apr 8, 2022
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #931 (f6c7290) into main (afa8f13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      242      242           
=======================================
  Hits         1375     1375           
  Misses        477      477           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa8f13...f6c7290. Read the comment docs.

@peternied
Add newlines to the end of files
fba6fd8 
Signed-off-by: Peter Nied <petern@amazon.com>
@cliu123
Copy link
Copy Markdown
Member

cliu123 commented Apr 8, 2022 •
edited
Loading

Please squash and remove the unnecessary commit messages when merging. : )

@peternied peternied merged commit 558a7e1 into opensearch-project:main Apr 8, 2022
@dblock dblock deleted the meta-templates branch April 12, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peternied peternied peternied approved these changes

@cliu123 cliu123 cliu123 approved these changes

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dblock @peternied @codecov-commenter @cliu123