Skip to content

[Backport 2.8] Fixing dynamic tenancy changes for issues 1412#1457

Merged
peterzhuamazon merged 2 commits intoopensearch-project:2.8from
cwperks:backport/backport-1419-to-2.8
May 31, 2023
Merged

[Backport 2.8] Fixing dynamic tenancy changes for issues 1412#1457
peterzhuamazon merged 2 commits intoopensearch-project:2.8from
cwperks:backport/backport-1419-to-2.8

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented May 31, 2023

Backport of #1419 to 2.8

@abhivka7 @stephen-crawford @cwperks
Fixing dynamic tenancy changes for issues 1412 (opensearch-project#1419)
dc3b0a5 
* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
(cherry picked from commit c4e6c37)
@RyanL1997
Copy link
Copy Markdown
Collaborator

RyanL1997 commented May 31, 2023

FYI: The prerequisite check will not block the merging.

@codecov
Copy link
Copy Markdown

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #1457 (dc2d304) into 2.8 (920e6eb) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##              2.8    #1457      +/-   ##
==========================================
- Coverage   65.51%   65.47%   -0.05%     
==========================================
  Files          93       93              
  Lines        2294     2297       +3     
  Branches      307      313       +6     
==========================================
+ Hits         1503     1504       +1     
- Misses        723      725       +2     
  Partials       68       68
Impacted Files Coverage Δ
...s/configuration/panels/tenant-list/tenant-list.tsx 3.44% <50.00%> (+3.44%) ⬆️
public/plugin.ts 12.69% <50.00%> (-0.21%) ⬇️
public/apps/account/account-nav-button.tsx 63.88% <100.00%> (ø)
...ps/configuration/panels/tenant-list/manage_tab.tsx 69.12% <100.00%> (ø)

@DarshitChanpura DarshitChanpura mentioned this pull request May 31, 2023
Closed
3 tasks
@cwperks
Update versions in new workflow
dc2d304 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented May 31, 2023

@DarshitChanpura @RyanL1997 I had to push a change to update the versions referenced in the new workflow. Since the workflow is testing the code introduced in this PR we should verify those checks before merging.

@peterzhuamazon
Copy link
Copy Markdown
Member

peterzhuamazon commented May 31, 2023 •
edited
Loading

Per @cwperks and @RyanL1997 this is a flaky test (12th run pass on this specific PR), which will be addressed in the next minor version.

Merge now.

Thanks.

@peterzhuamazon peterzhuamazon merged commit ae083f9 into opensearch-project:2.8 May 31, 2023
@peterzhuamazon peterzhuamazon mentioned this pull request May 31, 2023
Closed
42 tasks
@RyanL1997
Copy link
Copy Markdown
Collaborator

RyanL1997 commented May 31, 2023

Thanks @peterzhuamazon for the help on merging. Yes, this is a known flaky, and this fix has already planned to remove it for 2.8 branch

@peterzhuamazon
Copy link
Copy Markdown
Member

peterzhuamazon commented May 31, 2023

Thanks @peterzhuamazon for the help on merging. Yes, this is a known flaky, and this fix has already planned to remove it for 2.8 branch

Great thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarshitChanpura DarshitChanpura DarshitChanpura approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

+1 more reviewer

@stephen-crawford stephen-crawford stephen-crawford approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cwperks @RyanL1997 @peterzhuamazon @DarshitChanpura @stephen-crawford @abhivka7