Skip to content

Increment version to 1.3.9#1322

Merged
cwperks merged 3 commits intoopensearch-project:1.3from
RyanL1997:Increment-to-1.3.9
Mar 8, 2023
Merged

Increment version to 1.3.9#1322
cwperks merged 3 commits intoopensearch-project:1.3from
RyanL1997:Increment-to-1.3.9

Conversation

@RyanL1997
Copy link
Copy Markdown
Collaborator

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

Increment version to 1.3.9

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Maintenance

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997 RyanL1997 requested a review from a team February 10, 2023 23:11
@RyanL1997 RyanL1997 mentioned this pull request Feb 10, 2023
3 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #1322 (5729d08) into 1.3 (0a2b86f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              1.3    #1322   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files          88       88           
  Lines        1916     1916           
  Branches      250      245    -5     
=======================================
  Hits         1386     1386           
  Misses        474      474           
  Partials       56       56           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Location: /ci/dbc/distribution-build-opensearch/1.3.9/7067/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.9.0.zip [following]
--2023-02-10 23:12:30--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.9/7067/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.9.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden
2023-02-10 23:12:31 ERROR 403: Forbidden.

Looks like we need to fix this build to latest, @RyanL1997 can you look into this?

@RyanL1997
Copy link
Copy Markdown
Collaborator Author

RyanL1997 commented Feb 14, 2023

Location: /ci/dbc/distribution-build-opensearch/1.3.9/7067/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.9.0.zip [following]
--2023-02-10 23:12:30--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.9/7067/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.9.0.zip
Reusing existing connection to ci.opensearch.org:443.
HTTP request sent, awaiting response... 403 Forbidden
2023-02-10 23:12:31 ERROR 403: Forbidden.

Looks like we need to fix this build to latest, @RyanL1997 can you look into this?

@peternied Thanks for the review! I think it is the latest: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/4148396846/jobs/7231566838#step:9:66. The reason we are getting this 403 is that we are still awaiting for the version increment of the security backend and building artifact. There is no changes need to be applied for this one.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@peternied
Copy link
Copy Markdown
Member

@RyanL1997 We can't use maven because the 1.3 security plugin doesn't support publishing to maven #1331 (comment)

If you figure out how to get this supported in 1.3 then we can start publishing and consuming via maven.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Copy Markdown
Collaborator Author

Awaiting for the merge of opensearch-project/opensearch-build#3263, so that we can get the distribution build to unblock this PR

@RyanL1997
Copy link
Copy Markdown
Collaborator Author

@peternied Got it. For this one, we have added the security plugin to the manifest, and the CI is passing. I think we are good to merge this PR now.

@cwperks cwperks dismissed peternied’s stale review March 8, 2023 14:50

The changes requested have been addressed and latest is being pulled.

@cwperks
Copy link
Copy Markdown
Member

cwperks commented Mar 8, 2023

@peternied The change requested was addressed and latest is being pulled:

From the latest integration test output:

Run wget 'https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.9/latest/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.9.0.zip' --retry-connrefused --tries=3 --no-dns-cache --progress=bar:force:noscroll --verbose
--2023-03-08 01:44:16-- https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.9/latest/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.9.0.zip

@cwperks cwperks merged commit e8d87fd into opensearch-project:1.3 Mar 8, 2023
@cwperks cwperks mentioned this pull request Mar 8, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants