[Backport 1.0] Tenancy getting Lost in SAML Authentication#1122
Merged
cwperks merged 4 commits intoopensearch-project:1.0from Oct 7, 2022
Merged
[Backport 1.0] Tenancy getting Lost in SAML Authentication#1122cwperks merged 4 commits intoopensearch-project:1.0from
cwperks merged 4 commits intoopensearch-project:1.0from
Conversation
…flow (opensearch-project#1058) * Fix for picking up tenancy from local storage in SAML AuthN flow Signed-off-by: Aniketh Jain <anijainc@amazon.com> (cherry picked from commit 05649d6)
Signed-off-by: Aniketh Jain <anijainc@amazon.com>
Signed-off-by: Aniketh Jain <anijainc@amazon.com>
Signed-off-by: Aniketh Jain <anijainc@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.0 #1122 +/- ##
======================================
Coverage ? 74.15%
======================================
Files ? 85
Lines ? 1853
Branches ? 235
======================================
Hits ? 1374
Misses ? 425
Partials ? 54 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DarshitChanpura
approved these changes
Oct 5, 2022
Member
|
We will not be releasing 1.0, only versions 1.3, so this backport won't accomplish anything. Closing this pull request out. |
cwperks
approved these changes
Oct 6, 2022
peternied
requested changes
Oct 6, 2022
Member
peternied
left a comment
There was a problem hiding this comment.
Dup of #1126 (review)
I think there was a conversation that happen offline that would be good to include here, can we reference that before this change is merged
Contributor
Author
|
@peternied This has been included in the PR for release page. |
peternied
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix is for ensuring that tenancy information is read from the local storage in SAML Authentication workflow after a user log out of OS Dashboard.
Category
Bug Fix
Why these changes are required?
To have a good user experience and ensure their tenancy is reloaded after logging in into a new session in the same browser.
What is the old behavior before changes and new behavior after changes?
Tenancy information was not being read from local storage after logout in old behaviour for SAML authentication enabled domains. After the changes, tenancy information will be read from local storage. This is ensured as the session storage variable
pendistro::security::tenant::show_popupis set to null after logout in SAML Authentication workflow.Issues Resolved
Issue created for this bug
Testing
The changes have been made in security-dashboards-plugin and the same has been tested for OS Dashboards in SAML authentication enabled domains.
AfterFix_SAMLTenancyBug.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.