Allow detectors to be stopped if underlying workflow is deleted. Don't allow them to then be started/edited (#810)#963
Merged
engechas merged 1 commit intoopensearch-project:2.xfrom Apr 4, 2024
Conversation
…t allow them to then be started/editted (opensearch-project#810) * Allow detectors to be stopped if underlying workflow is deleted. Don't allow them to then be started Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Add copyright headers Signed-off-by: Chase Engelbrecht <engechas@amazon.com> --------- Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #963 +/- ##
============================================
- Coverage 25.02% 24.77% -0.26%
- Complexity 1041 1052 +11
============================================
Files 277 279 +2
Lines 12755 12888 +133
Branches 1391 1403 +12
============================================
+ Hits 3192 3193 +1
- Misses 9289 9422 +133
+ Partials 274 273 -1 ☔ View full report in Codecov by Sentry. |
riysaxen-amzn
approved these changes
Apr 4, 2024
jowg-amazon
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #810 to 2.x
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.