* #709 Return empty response for empty mappings and no applied aliases#765
Merged
jowg-amazon merged 1 commit intoopensearch-project:2.7from Dec 14, 2023
Merged
Conversation
… no applied aliases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.7 #765 +/- ##
============================================
- Coverage 28.17% 28.13% -0.04%
Complexity 895 895
============================================
Files 231 231
Lines 9343 9343
Branches 1075 1075
============================================
- Hits 2632 2629 -3
- Misses 6474 6477 +3
Partials 237 237 ☔ View full report in Codecov by Sentry. |
eirsep
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Returns an empty response instead of exception in case of:
Issues Resolved
#709
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.