[Backport 2.x] #709 Return empty response for empty mappings and no applied aliases#747
Merged
jowg-amazon merged 1 commit into2.xfrom Dec 1, 2023
Merged
Conversation
…724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit c0f7bd9)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #747 +/- ##
============================================
- Coverage 24.82% 24.80% -0.03%
Complexity 1019 1019
============================================
Files 275 275
Lines 12671 12671
Branches 1390 1390
============================================
- Hits 3146 3143 -3
- Misses 9257 9260 +3
Partials 268 268 ☔ View full report in Codecov by Sentry. |
jowg-amazon
approved these changes
Nov 30, 2023
eirsep
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport c0f7bd9 from #724