[Backport 2.x] #725 Sigma keywords field not handled correctly#739
Merged
jowg-amazon merged 1 commit into2.xfrom Jan 17, 2024
Merged
[Backport 2.x] #725 Sigma keywords field not handled correctly#739jowg-amazon merged 1 commit into2.xfrom
jowg-amazon merged 1 commit into2.xfrom
Conversation
* changed windows sample rule and query construction Signed-off-by: Joanne Wang <jowg@amazon.com> * remove wildcard Signed-off-by: Joanne Wang <jowg@amazon.com> * changed wildcardtest Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed wildcards Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed wildcard query test Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed correlation engine tests Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed query backend tests Signed-off-by: Joanne Wang <jowg@amazon.com> * clean up Signed-off-by: Joanne Wang <jowg@amazon.com> * added two integration tests Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 43040d6)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #739 +/- ##
============================================
- Coverage 24.82% 24.77% -0.05%
Complexity 1019 1019
============================================
Files 275 275
Lines 12671 12664 -7
Branches 1390 1389 -1
============================================
- Hits 3146 3138 -8
- Misses 9257 9260 +3
+ Partials 268 266 -2 ☔ View full report in Codecov by Sentry. |
amsiglan
approved these changes
Dec 19, 2023
jowg-amazon
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 43040d6 from #725