Using alerting workflows in detectors (#394)#533
Merged
eirsep merged 4 commits intoopensearch-project:mainfrom Sep 6, 2023
Merged
Using alerting workflows in detectors (#394)#533eirsep merged 4 commits intoopensearch-project:mainfrom
eirsep merged 4 commits intoopensearch-project:mainfrom
Conversation
Enables workflow creation - all the monitors related with the given detector will be part of the detector Enables workflow update during detector update Deletes the workflow during the detector deletion Adds additional field to a detector Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
…isabled flag Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #533 +/- ##
============================================
- Coverage 25.72% 25.43% -0.29%
- Complexity 938 943 +5
============================================
Files 252 254 +2
Lines 10768 10933 +165
Branches 1197 1205 +8
============================================
+ Hits 2770 2781 +11
- Misses 7749 7901 +152
- Partials 249 251 +2
|
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
approved these changes
Sep 6, 2023
Collaborator
There was a problem hiding this comment.
pr looks good. approving the pr. but we need to work on the bucket-level trigger impl. https://github.com/opensearch-project/security-analytics/pull/533/files#diff-8fa8978eef6244554fff1512eb4ed63755d995cf3e8aa295522657a4eecb6166R775
getsaurabh02
approved these changes
Sep 6, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cb5ddc79d8a76ad722997f48d7c57f203c56d8a
# Push it to GitHub
git push --set-upstream origin backport/backport-533-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables workflow creation - all the monitors related with the given detector will be part of the detector Enables workflow update during detector update
Deletes the workflow during the detector deletion
Adds additional field to a detector