Refactored config REST API tests to avoid unsafe patterns causing memory leaks#5934
Merged
DarshitChanpura merged 1 commit intoopensearch-project:mainfrom Feb 6, 2026
Merged
Conversation
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
Collaborator
Author
|
This should fix the remaining memory leak test issues. This is a big change, but it is a quite schematic code change. |
cwperks
reviewed
Feb 2, 2026
src/integrationTest/java/org/opensearch/security/api/AbstractApiIntegrationTest.java
Show resolved
Hide resolved
Member
|
@nibix Any idea why this shows up ~700 times in the output? Edit: More of the stack trace: |
Member
|
Looks like the DLS clause in |
Collaborator
Author
Before we removed the randomized testing framework, these were just random strings. I was under the impression that validation was tested here, but I am not sure. |
Member
|
@willyborankin @DarshitChanpura can we get another review on this? |
DarshitChanpura
approved these changes
Feb 6, 2026
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
LGTM. Thanks @nibix .
f56424b
into
opensearch-project:main
254 of 260 checks passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5934 +/- ##
==========================================
- Coverage 73.83% 0 -73.84%
==========================================
Files 439 0 -439
Lines 26884 0 -26884
Branches 3980 0 -3980
==========================================
- Hits 19851 0 -19851
+ Misses 5148 0 -5148
+ Partials 1885 0 -1885 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #5915, we discovered that the config REST API integration tests cause memory leaks as they use static references across test class boundaries in an unsafe manner.
This PR refactores these tests so that these no longer share static cluster or mutable static configuration references across test classes. IMHO, one should strive for abolishing the abstract super classes for these tests alltogether, but this is outside of my time availability.
Issues Resolved
Fixes #5915
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.