[Forwardport main] Switch to supportsImpersonation check for http auth backend and add Privileged Action for JwtParserBuilder #3579
Merged
stephen-crawford merged 2 commits intoopensearch-project:mainfrom Oct 24, 2023
Conversation
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3579 +/- ##
============================================
+ Coverage 64.99% 65.01% +0.01%
- Complexity 3644 3648 +4
============================================
Files 282 283 +1
Lines 20613 20619 +6
Branches 3391 3392 +1
============================================
+ Hits 13398 13405 +7
Misses 5535 5535
+ Partials 1680 1679 -1
|
supportsImpersonation check for http auth backendSigned-off-by: Ryan Liang <jiallian@amazon.com>
Member
|
@RyanL1997 Can you update the name of this PR to something more pertinent to the content of the changes that could be placed in release notes? |
supportsImpersonation check for http auth backend and add Privileged Action for JwtParserBuilder
Collaborator
Author
|
Sure @cwperks, I just updated that. |
peternied
approved these changes
Oct 23, 2023
stephen-crawford
approved these changes
Oct 24, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch to
supportsImpersonationcheck for http auth backend + wrap JwtParserBuilder withdoPrivilegedReference to @cwperks's comment:
Enhancement
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
It has already been included in
2.xCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.