[Enhancement] Setup auth token utils for obo#3419
Merged
RyanL1997 merged 8 commits intoopensearch-project:mainfrom Oct 2, 2023
Merged
[Enhancement] Setup auth token utils for obo#3419RyanL1997 merged 8 commits intoopensearch-project:mainfrom
RyanL1997 merged 8 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3419 +/- ##
============================================
+ Coverage 64.23% 64.52% +0.28%
- Complexity 3490 3546 +56
============================================
Files 264 269 +5
Lines 20152 20363 +211
Branches 3363 3375 +12
============================================
+ Hits 12945 13139 +194
+ Misses 5530 5529 -1
- Partials 1677 1695 +18
|
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
Left some suggestions to clean up code.
src/main/java/org/opensearch/security/securityconf/DynamicConfigModelV7.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/authtoken/jwt/JwtVendor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/authtoken/jwt/JwtVendor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Collaborator
Author
|
Hi @DarshitChanpura, thanks for the feedbacks. I have applied those changes. |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
DarshitChanpura
previously approved these changes
Sep 29, 2023
stephen-crawford
previously approved these changes
Oct 2, 2023
Contributor
|
Should probably add unit tests but because of the timeline for the 2.11 release, we can make do with a fast follow-up in my opinion. |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
d76ee00
Signed-off-by: Ryan Liang <jiallian@amazon.com>
stephen-crawford
approved these changes
Oct 2, 2023
DarshitChanpura
approved these changes
Oct 2, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ffa23cc96a6bf96752c33b7f134e4e6139dc828
# Push it to GitHub
git push --set-upstream origin backport/backport-3419-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
Collaborator
Author
|
Btw the unit tests has been added for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setup auth token utils for obo
Enhancement, New feature
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.