Skip to content

[Backport 2.x] Enable jarhell check#3228

Merged
peternied merged 1 commit into
2.xfrom
backport/backport-3227-to-2.x
Aug 24, 2023
Merged

[Backport 2.x] Enable jarhell check#3228
peternied merged 1 commit into
2.xfrom
backport/backport-3227-to-2.x

Conversation

@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

Backport 75f529a from #3227.

JarHell was disabled due to an issue with Kafka where there were
multiple copies of the same class packaged inside of a release and test
distribution jar. This was resolved with
apache/kafka#12407

The Kafka change has been merged, released, and pulled into this
repository so we are removing the workaround to supress jar hell issue
detection.

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 75f529a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Aug 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3228 (c98f764) into 2.x (1bb6df5) will decrease coverage by 0.02%.
Report is 2 commits behind head on 2.x.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3228      +/-   ##
============================================
- Coverage     62.35%   62.34%   -0.02%     
  Complexity     3296     3296              
============================================
  Files           252      252              
  Lines         19469    19469              
  Branches       3308     3308              
============================================
- Hits          12140    12137       -3     
- Misses         5711     5716       +5     
+ Partials       1618     1616       -2     

see 4 files with indirect coverage changes

@DarshitChanpura

Copy link
Copy Markdown
Member

Code-ql blocked by: #3230

@peternied peternied merged commit abeedb1 into 2.x Aug 24, 2023
@peternied peternied deleted the backport/backport-3227-to-2.x branch August 24, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants