[Backport 2.x] Change password security message (#3057)#3203
Merged
peternied merged 5 commits intoopensearch-project:2.xfrom Aug 22, 2023
Merged
[Backport 2.x] Change password security message (#3057)#3203peternied merged 5 commits intoopensearch-project:2.xfrom
peternied merged 5 commits intoopensearch-project:2.xfrom
Conversation
Returns the error message instead of the validation message because validation message should already have been shown in above case statements. Fix: opensearch-project#3055 Is this a backport? If so, please add backport PR # and/or commits # [Please provide details of testing done: unit testing, integration testing and manual testing] - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 847f911)
src/main/java/org/opensearch/security/dlic/rest/validation/PasswordValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/validation/PasswordValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/validation/PasswordValidator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/validation/PasswordValidatorTest.java
Outdated
Show resolved
Hide resolved
Fix merge conflicts Signed-off-by: Derek Ho <dxho@amazon.com>
Fix merge conflicts Signed-off-by: Derek Ho <dxho@amazon.com>
Member
|
@derek-ho I've updated the description and the title of the issue to capture its 'backportness' Looks like there are still CI failures, can you look into them? |
Fix final merge conflict Signed-off-by: Derek Ho <dxho@amazon.com>
Member
|
@derek-ho Still looks broken, happy to take another look after CI is passing. Let us know if you need a hand. |
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #3203 +/- ##
============================================
- Coverage 62.35% 62.34% -0.02%
+ Complexity 3296 3294 -2
============================================
Files 252 252
Lines 19469 19467 -2
Branches 3308 3308
============================================
- Hits 12140 12136 -4
+ Misses 5711 5710 -1
- Partials 1618 1621 +3
|
Collaborator
Author
|
@peternied should be fixed now, sorry. It was blocked on backported API changes, should have called that out to avoid any confusion. |
peternied
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports 847f911 from #3057
Returns the error message instead of the validation message because validation message should already have been shown in above case statements.
Signed-off-by: Craig Perkins cwperx@amazon.com
Signed-off-by: Derek Ho dxho@amazon.com
Co-authored-by: Craig Perkins cwperx@amazon.com
(cherry picked from commit 847f911)