Skip to content

[Backport 2.x] Fix build after Lucene upgrade and breaking XContentFactory changes (#3069)#3075

Merged
peternied merged 1 commit intoopensearch-project:2.xfrom
cwperks:backport-3064-2.x
Jul 31, 2023
Merged

[Backport 2.x] Fix build after Lucene upgrade and breaking XContentFactory changes (#3069)#3075
peternied merged 1 commit intoopensearch-project:2.xfrom
cwperks:backport-3064-2.x

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Jul 31, 2023

Backport #3069 to 2.x

…pensearch-project#3069)

There are multiple PRs in core affecting the security plugin that the
security plugin needs to adapt to.

- opensearch-project/OpenSearch#7792
- opensearch-project/OpenSearch#8826
- opensearch-project/OpenSearch#8668

I am opening a Draft PR that includes a fix for the Lucene-related test
failures which was caused by
opensearch-project/OpenSearch#7792

Resolves: opensearch-project#3064

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 08d1734)
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3075 (73d553f) into 2.x (11041cd) will increase coverage by 25.94%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##                2.x    #3075       +/-   ##
=============================================
+ Coverage     36.27%   62.21%   +25.94%     
- Complexity     1879     3312     +1433     
=============================================
  Files           265      265               
  Lines         19488    19497        +9     
  Branches       3328     3328               
=============================================
+ Hits           7069    12131     +5062     
+ Misses        11314     5738     -5576     
- Partials       1105     1628      +523     
Files Changed Coverage Δ
...security/configuration/DlsFlsFilterLeafReader.java 61.52% <100.00%> (+43.55%) ⬆️
.../org/opensearch/security/support/ConfigHelper.java 86.53% <100.00%> (+26.92%) ⬆️
...a/org/opensearch/security/tools/SecurityAdmin.java 41.37% <100.00%> (+41.37%) ⬆️

... and 145 files with indirect coverage changes

@peternied peternied merged commit d925d8c into opensearch-project:2.x Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants