GitHub Action for plugin install #2239
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2239 +/- ##
============================================
+ Coverage 61.02% 61.04% +0.01%
- Complexity 3267 3268 +1
============================================
Files 259 259
Lines 18337 18337
Branches 3248 3248
============================================
+ Hits 11191 11193 +2
+ Misses 5561 5559 -2
Partials 1585 1585
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f8350f8 to
4bbbb06
Compare
peternied
left a comment
There was a problem hiding this comment.
Great work, lets try to condense some of these steps to have fewer platform specific code paths and fewer inputs, looks really close!
|
@peternied this should be all set now. |
peternied
left a comment
There was a problem hiding this comment.
Please add those tests back in, and I think there might be some issues with the workflow setting up the linux instance correctly.
|
@cwperks @peternied @DarshitChanpura This should be all set. |
|
This pull request is pointed to the 2.4 branch, but we are past feature freeze. Seems like we should point it to main, what do you think? |
Main does not have a stable windows build is the reason this is on 2.4. |
|
If we can't get it working on main, then we should go into 2.X - do you have a link to the issue about windows being unavailable? |
|
opensearch-project/opensearch-build#2754 At the bottom of the page, it is mentioned that there was not a successful build for 3.0. This may have changed but I have been working on this for a while so I think when I started it was still not there. I can move this up to being based on 3 and see what happens but I am not sure how to confirm one-way or the other whether the main is not a viable base. |
227ff17 to
4e7bc51
Compare
|
I think you need to rebase your changes with something like |
|
I did and resolved all the conflicts. Not sure why it is not running the checks again but you can see it is up-to-date with main. I will try again. |
|
I don't think the rebase / force push worked. If you look at the pull request there is 125 commits in this change. Maybe squash and force push |
fed0cff to
47c9017
Compare
|
I don't see any changes? Just in case I have found this useful too https://ohshitgit.com/ |
8d13acf to
de51dc1
Compare
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
|
|
|
@cwperks what do you think about merging this? |
cwperks
left a comment
There was a problem hiding this comment.
Great work on the abstraction of the github action to promote re-usability! Left a few suggestions, and one area that needs to be addressed. The section on integTests is not working, can you look into it?
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
9cee894 to
c477372
Compare
|
I am not sure why this stopped working all of a sudden. |
68bc9fe to
705f9d9
Compare
|
Seems there is something wrong with gradle and not the code so I will reflog my changes and then see where that gets us once it is fixed. |
e06fc10 to
c477372
Compare
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
bd7c12e to
15c4005
Compare
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
ffb6e0c to
15c4005
Compare
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
cwperks
left a comment
There was a problem hiding this comment.
Great work, thank you @scrawfor99!
Description
Converts the security plugin install into a git hub action action.yml process instead of a workflow.
Partially resolves issue #2207
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Completed check on 2.4 branch for windows and linux os with jdk 11 and 17.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.