Skip to content

OpenSSLTest is not using the OpenSSL Provider#2219

Closed
reta wants to merge 1 commit intoopensearch-project:mainfrom
reta:issue-2208
Closed

OpenSSLTest is not using the OpenSSL Provider#2219
reta wants to merge 1 commit intoopensearch-project:mainfrom
reta:issue-2208

Conversation

@reta
Copy link
Copy Markdown
Collaborator

@reta reta commented Nov 2, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

OpenSSLTest should be using the OpenSSL Provider. There are few issues with netty-tcnative and OpenSSL:

Issues Resolved

Closes #2208

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 2, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.03%. Comparing base (89a11c5) to head (00c7a05).
⚠️ Report is 1377 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2219      +/-   ##
============================================
- Coverage     61.06%   61.03%   -0.04%     
+ Complexity     3269     3268       -1     
============================================
  Files           259      259              
  Lines         18335    18335              
  Branches       3248     3248              
============================================
- Hits          11196    11190       -6     
- Misses         5553     5559       +6     
  Partials       1586     1586              

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarshitChanpura
Copy link
Copy Markdown
Member

Bwc tests are broken on main. Tracking issue here: #2221

@DarshitChanpura
Copy link
Copy Markdown
Member

Bwc tests are broken on main. Tracking issue here: #2221

@reta this should be unblocked now

@peternied
Copy link
Copy Markdown
Member

@reta Any thoughts on this PR? Seems like this work has stalled

@reta
Copy link
Copy Markdown
Collaborator Author

reta commented Dec 5, 2022

@reta Any thoughts on this PR? Seems like this work has stalled

@peternied I think we decided to drop support for OpenSSL (due to numerous limitations mentioned in description), the pull request in the current form will work only if OpenSSL 1.0.0 is present in the system (which is way outdated). The other options which some projects are doing is to prebuild netty-tcnative-openssl-static-{os_arch} binaries (since those are not available by default). WDYT?

@peternied
Copy link
Copy Markdown
Member

I'm going to close this pull request. If anything changes we can reopen in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] OpenSSLTest is not using the OpenSSL Provider

4 participants