Conversation
… (#1924) We were seeing test failures where on higher end computers there would be duplicate audit messages for the index mapping creation. Then when run inside GitHub Actions there would only be 2 messages. This doesn't look like an overt product issue, overlogging of requests, but the test case was not handling it well. Also improved the failure message response for faster future debugging. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 1904db5) Co-authored-by: Peter Nied <petern@amazon.com>
Member
Author
|
@DarshitChanpura I created this PR because the label for backport 2.1 didn't appear, do you know anything about that? |
Codecov Report
@@ Coverage Diff @@
## 2.1 #1925 +/- ##
============================================
+ Coverage 60.95% 61.05% +0.09%
- Complexity 3231 3236 +5
============================================
Files 256 256
Lines 18087 18088 +1
Branches 3224 3224
============================================
+ Hits 11025 11043 +18
+ Misses 5478 5464 -14
+ Partials 1584 1581 -3
Continue to review full report at Codecov.
|
cliu123
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backporting this from 2.x branch
We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation. Then when
run inside GitHub Actions there would only be 2 messages. This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.
Signed-off-by: Peter Nied petern@amazon.com
(cherry picked from commit 1904db5)
Co-authored-by: Peter Nied petern@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.