Update 'main' branch to build against 3.0.0#117
Merged
noCharger merged 1 commit intoopensearch-project:mainfrom Mar 13, 2023
Merged
Update 'main' branch to build against 3.0.0#117noCharger merged 1 commit intoopensearch-project:mainfrom
noCharger merged 1 commit intoopensearch-project:mainfrom
Conversation
Following our semver policy, the main branch shoudl track the next major version. There was an XContent refactor in 3.x that required some imports to be fixed to find classes in their new locations. Also, REST client now uses Apache HTTPClient 5. Signed-off-by: Michael Froh <froh@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #117 +/- ##
=========================================
Coverage 80.93% 80.93%
Complexity 215 215
=========================================
Files 29 29
Lines 881 881
Branches 120 120
=========================================
Hits 713 713
Misses 106 106
Partials 62 62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
noCharger
reviewed
Mar 10, 2023
Collaborator
noCharger
left a comment
There was a problem hiding this comment.
Thanks for the change. Any plan to update versioning in this PR? Example
src/test/java/org/opensearch/search/relevance/SearchRelevancePluginIT.java
Show resolved
Hide resolved
noCharger
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following our semver policy, the main branch shoudl track the next major version.
There was an XContent refactor in 3.x that required some imports to be fixed to find classes in their new locations. Also, REST client now uses Apache HTTPClient 5.
Issues Resolved
#116 - Updating search-processor for XContentType refactor
#114 - main branch should be tracking 3.0.0
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.