[backport 1.3] Enable windows build (#561)#562
Merged
rupal-bq merged 1 commit intoopensearch-project:1.3from Dec 2, 2022
rupal-bq:backport/backport-561-to-1.3
Merged
[backport 1.3] Enable windows build (#561)#562rupal-bq merged 1 commit intoopensearch-project:1.3from rupal-bq:backport/backport-561-to-1.3
rupal-bq merged 1 commit intoopensearch-project:1.3from
rupal-bq:backport/backport-561-to-1.3
Conversation
* feat: enable windows and macos build (#504) Signed-off-by: Derek Ho <dxho@amazon.com> * Remove macos Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove macos from dashboards report Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix build Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update setup node for linux Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Derek Ho <derek01778@gmail.com> (cherry picked from commit 6efd7b1)
joshuali925
approved these changes
Dec 2, 2022
Codecov Report
@@ Coverage Diff @@
## 1.3 #562 +/- ##
============================================
+ Coverage 74.57% 77.38% +2.80%
============================================
Files 94 30 -64
Lines 4008 1910 -2098
Branches 612 383 -229
============================================
- Hits 2989 1478 -1511
+ Misses 885 429 -456
+ Partials 134 3 -131
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sejli
approved these changes
Dec 2, 2022
kavithacm
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #561 to 1.3 branch
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.