[migration] Rename elasticsearch to opensearch for reports-scheduler#5
Merged
joshuali925 merged 4 commits intodevfrom Apr 19, 2021
Merged
[migration] Rename elasticsearch to opensearch for reports-scheduler#5joshuali925 merged 4 commits intodevfrom
joshuali925 merged 4 commits intodevfrom
Conversation
dblock
reviewed
Apr 16, 2021
| import re | ||
|
|
||
| link_prefix = "https://github.com/opendistro-for-elasticsearch/kibana-reports/reports-scheduler" | ||
| link_prefix = "https://github.com/opendistro-for-opensearch/kibana-reports/reports-scheduler" |
Member
There was a problem hiding this comment.
Lots of opendistro-for-opensearch here, and kibana's, all these seem wrong.
dblock
suggested changes
Apr 19, 2021
Member
dblock
left a comment
There was a problem hiding this comment.
The AWS secret key def. needs to be fixed, the rest look A-OK.
reports-scheduler/build.gradle
Outdated
| url = 's3://search-vemsarat/' | ||
| credentials(AwsCredentials) { | ||
| accessKey = System.env.AWS_ACCESS_KEY_ID ?: findProperty('aws_access_key_id') | ||
| secretKey = System.env.AWS_ACCESS_KEY_ID ?: findProperty('aws_secret_access_key') |
Member
There was a problem hiding this comment.
This should be AWS_ACCESS_SECRET_KEY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.