Conversation
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: David Cui <davidcui@amazon.com> Co-authored-by: Carl Meadows <47793022+CarlMeadows@users.noreply.github.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: David Cui <davidcui@amazon.com>
…#37) Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: David Cui <davidcui@amazon.com>
… specified or when the match phrases is negated (#33) * [Build query] Correctly handle phrases filter that specify only one single value Contrary to the phrase filter type which always specify a meta.params.query, the phrases filter type never specify a meta.params.query even when a single value is selected. This anomaly trigger an error generated by the MonoFieldQueryBase included in the elastic-builder dependency and prevent the generation of the report. Signed-off-by: Kévin Masseix <masseix.kevin@gmail.com> * [Build query] Correctly handle negated phrases filter that specify only one single value Signed-off-by: Kévin Masseix <masseix.kevin@gmail.com> * [Build query] Correctlty handle negated phrases to exclude them from the report instead of including them Signed-off-by: Kévin Masseix <masseix.kevin@gmail.com>
Pass processing if doc[field] == null Based on opendistro-for-elasticsearch/kibana-reports#327 (comment)
Add missing test case for the fix "pass doc[field] == null"
… Kibana advanced setting (#371)
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
* Fix csv parsing function Signed-off-by: Joshua Li <joshuali925@gmail.com> * Flatten nested results for csv Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add test case for nested fields Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: David Cui <davidcui@amazon.com>
…perbound 2 (#62) Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
* add puml diagrams for integration with Notifications plugin Signed-off-by: David Cui <davidcui@amazon.com> * amend Notifications plugin naming in diagram Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Also a issue with chrome font rendering was fixed
* moved docs to root folder, update readme to include Notifications roadmap Signed-off-by: David Cui <davidcui@amazon.com> * update readme to clarify current status of supported features Signed-off-by: David Cui <davidcui@amazon.com>
Add auto-backport and auto-delete workflows for reporting Signed-off-by: David Cui <davidcui@amazon.com>
* change default CI version to JDK 11, add JDK versions to CI matrix and document changes in developer guide Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
exclude centos links from linkchecker Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Version Increment to 1.3.3 OpenSearch release
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Incremented version to 1.3.4. Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Add JS snapshot Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.x #403 +/- ##
======================================
Coverage ? 72.95%
Complexity ? 373
======================================
Files ? 94
Lines ? 3946
Branches ? 611
======================================
Hits ? 2879
Misses ? 892
Partials ? 175
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
joshuali925
approved these changes
Jul 28, 2022
davidcui1225
approved these changes
Jul 28, 2022
Contributor
davidcui1225
left a comment
There was a problem hiding this comment.
LGTM but I see the DCO check failed
Member
Author
Those are for older commits, should be fine. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating 1.x branch with latest from 1.3.x
Issues Resolved
#396
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.