Closed
Conversation
fix opensearch-project#281 changes regex to allow additional customized ids instead of ids in uuid format only.
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
============================================
+ Coverage 72.70% 77.11% +4.41%
============================================
Files 94 30 -64
Lines 3924 1866 -2058
Branches 608 374 -234
============================================
- Hits 2853 1439 -1414
+ Misses 895 424 -471
+ Partials 176 3 -173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zhongnansu
reviewed
Mar 2, 2022
Member
zhongnansu
left a comment
There was a problem hiding this comment.
I am OK with the change. But for us to merge this PR, you need to do the following
- change your PR title to something descriptive
- sign your commit with DCO, so github workflow will pass. you can refer to https://www.secondstate.io/articles/dco/
Member
|
We want to get this out in 1.3. If the contributor doesn't reply to comments and update PR by March 7th. The team will clost the PR and post another one with correct signature. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #281
changes regex to allow additional customized ids instead of ids in uuid format only.
Description
Better would be /(?:[0-9a-z]+-[0-9a-z]+)+?/ as regex expression because of non-capturing group.
Or to allow only a certain range of characters: /(?:/)([0-9a-z-]{1,100})?/
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.