[1.2] removing jcenter from gradle.build#277
Merged
ps48 merged 5 commits intoopensearch-project:1.2from Jan 13, 2022
Merged
Conversation
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.2 #277 +/- ##
=========================================
Coverage 64.54% 64.54%
Complexity 294 294
=========================================
Files 97 97
Lines 4045 4045
Branches 620 620
=========================================
Hits 2611 2611
Misses 1293 1293
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
davidcui1225
approved these changes
Jan 13, 2022
zhongnansu
approved these changes
Jan 13, 2022
Member
zhongnansu
left a comment
There was a problem hiding this comment.
I assume we need another PR to main as well?
Member
Author
yes on it 💯 Also need to backport all the way upto 1.0 🔢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build failure due to jcenter being in Reports-Scheduler. Detekt package was being used from jcenter repository. Maven Central just keeps the latest version of package as of now. Therefore, replaced jcenter with plugins.gradle to fetch the package of same version.
Issues Resolved
#276
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.